Fix #2024: Use a shared Scope in the sbt plugin for all parallel tasks #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we instead pass down a more appropriate We can use sbt's |
WojciechMazur
force-pushed
the
fix/dont_acquire_jar_filesystem
branch
from
32e9fb9
to
b000154
Compare
WojciechMazur
changed the title
|
@sjrd I've changed the implementation to use shared scope instead as you hinted. |
sjrd
requested changes
Nov 30, 2020
util/src/main/scala/scala/scalanative/util/SharedScopeProvider.scala
Outdated
Show resolved
Hide resolved
sbt-scala-native/src/main/scala/scala/scalanative/sbtplugin/ScalaNativePluginInternal.scala
Outdated
Show resolved
Hide resolved
sjrd
requested changes
Nov 30, 2020
sbt-scala-native/src/main/scala/scala/scalanative/sbtplugin/ScalaNativePluginInternal.scala
Show resolved
Hide resolved
sjrd
approved these changes
Nov 30, 2020
sjrd
changed the title
ekrich
pushed a commit
to ekrich/scala-native
that referenced
this pull request
May 21, 2021
…arallel tasks (scala-native#2039) When creating a `JarDirectory`, it creates a new `FileSystem` with a URI based on the jar path. It is acquired by the enclosing `Scope`, and closed after that scope is closed. When building a single application, it does not yield any problem. However, when there are multiple modules linked into executables in parallel, exiting one of the `Scope`s may close a `FileSystem´ that is still used in other threads. It may result in a `ClosedFileSystemException`. This commit introduces a shared Scope used by tasks running as part of the same command, and closed in sbt's `onComplete` event. We also change the implementation of `Scope` to use an `AtomicReference` instead of a `var`, so that `Scope` itself becomes thread-safe.
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Aug 25, 2021
…arallel tasks (scala-native#2039) When creating a `JarDirectory`, it creates a new `FileSystem` with a URI based on the jar path. It is acquired by the enclosing `Scope`, and closed after that scope is closed. When building a single application, it does not yield any problem. However, when there are multiple modules linked into executables in parallel, exiting one of the `Scope`s may close a `FileSystem´ that is still used in other threads. It may result in a `ClosedFileSystemException`. This commit introduces a shared Scope used by tasks running as part of the same command, and closed in sbt's `onComplete` event. We also change the implementation of `Scope` to use an `AtomicReference` instead of a `var`, so that `Scope` itself becomes thread-safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR resolves #2024
When creating
JarDirectoryit creates a newFileSystemwith URI based on jar path. It's acquired intoScope, registered global filesystems register, and closed after exiting it. In normal conditions when we're building only a singleAppit does not yield any problems. However, when there are multiple modules linked into executables in parallel exitingScopemay close FileSystem that is still used in other threads. It may result inClosedFileSystemExceptionThis PR removes acquiring the mentioned FieleSystem. It means also means it would not be closed as before.JarDirectory currently is the only place using
Scope, so we may try to remove it entirely from the codebase.This PR introduces shared scope used in multiple builds and closed on
onCompletesbt event. It also changes implementation ofScopetoAtomicReferenceinstead ofvar