/bug

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade repl to jline 3 #11367

Open
adriaanm opened this Issue Aug 8, 2018 · 9 comments

Comments

Assignees

@adriaanm adriaanm

@som-snytt som-snytt

Labels
has PR repl
Projects
None yet
Milestone
  2.13.0-RC1
4 participants
@adriaanm @som-snytt @fommil @hvesalai
@adriaanm
Copy link
Member

adriaanm commented Aug 8, 2018

I was sure I already had a ticket, but can't find it. We should do this by RC1. The other scheduled REPL improvements will have to wait until 2.13.x.

@adriaanm adriaanm self-assigned this Aug 8, 2018

@som-snytt

This comment has been minimized.

Sign in to view
Copy link

som-snytt commented Aug 11, 2018

I'm looking into this today. It's non-trivial, but I'm more or less familiar with the previous state of affairs.
@fommil

This comment has been minimized.

Sign in to view
Copy link

fommil commented Sep 7, 2018

@hvesalai FYI ^^^
@hvesalai

This comment has been minimized.

Sign in to view
Copy link

hvesalai commented Sep 7, 2018 •
edited

What what? Didn't I do this already? nope

I did this: scala/scala#6478
@fommil

This comment has been minimized.

Sign in to view
Copy link

fommil commented Sep 7, 2018

@hvesalai yeah, I thought you'd be the right guy for the job 😆
@som-snytt

This comment has been minimized.

Sign in to view
Copy link

som-snytt commented Sep 7, 2018

I worked on this, so I'll take a look. I haven't had time the past month...
@fommil

This comment has been minimized.

Sign in to view
Copy link

fommil commented Sep 7, 2018

sheesh @som-snytt , jline4 will be out by then... 😜
@adriaanm

This comment was marked as outdated.

Sign in to view
Copy link
Member Author

adriaanm commented Jan 16, 2019 •
edited

I'd still like to see if we can get this into a 2.13.0-RC1! 🎉 .x release, but the ship has likely sailed for 2.13.0. EDIT: I missed the WIP PR, sorry!

@adriaanm adriaanm transferred this issue from scala/scala-dev Jan 16, 2019

@adriaanm adriaanm added this to the 2.13.1 milestone Jan 16, 2019

@adriaanm adriaanm added the repl label Jan 16, 2019

@som-snytt

This comment has been minimized.

Sign in to view
Copy link

som-snytt commented Jan 16, 2019

WIP scala/scala#7645

@som-snytt som-snytt referenced this issue Jan 16, 2019

Closed

Use JLine3 #7645

0 of 9 tasks complete
@adriaanm

This comment has been minimized.

Sign in to view
Copy link
Member Author

adriaanm commented Jan 16, 2019

Excellent, thanks @som-snytt!

@adriaanm adriaanm modified the milestones: 2.13.1, 2.13.0-RC1 Jan 16, 2019

@adriaanm adriaanm assigned som-snytt Jan 16, 2019

@adriaanm adriaanm added the has PR label Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment