Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No colours in the REPL? #11548

Closed
dwijnand opened this issue May 31, 2019 · 14 comments · Fixed by scala/scala#8711
Closed

No colours in the REPL? #11548

dwijnand opened this issue May 31, 2019 · 14 comments · Fixed by scala/scala#8711
Assignees
Milestone

Comments

@dwijnand
Copy link
Member

It looks to me like there are no more colours in the REPL:

image

Using -Dscala.color=true doesn't fix it either.

@dwijnand dwijnand added the repl label May 31, 2019
@dwijnand dwijnand added this to the 2.13.1 milestone May 31, 2019
@SethTisue
Copy link
Member

@som-snytt does this ring a bell?

@hrhino
Copy link

hrhino commented May 31, 2019

prio:blocker

@SethTisue
Copy link
Member

Scala 2.13.0:

24a847cebdc0a989471786805b7c7a36

Scala 2.13.1:

emerald-city

@adriaanm
Copy link
Contributor

This feature will be available only in Scala EE henceforth.

@smarter
Copy link
Member

smarter commented May 31, 2019

Meanwhile, in Dotty-land:
CM-Manila_thumb

@lrytz
Copy link
Member

lrytz commented Jul 25, 2019

Started working on this, here's a WIP for Scala EE license checking: scala/scala@4177daa

@szeiger
Copy link

szeiger commented Aug 20, 2019

Has anyone looked into the actual bug? Possibly related to the changes in JLine initialization (#11654)?

@adriaanm
Copy link
Contributor

Let's first get the jline3 upgrade merged and then see about this.

@szeiger szeiger modified the milestones: 2.13.1, 2.13.2 Sep 9, 2019
@SethTisue
Copy link
Member

Guillaume's image link went 404, so I took the liberty of replacing it.

@SethTisue
Copy link
Member

SethTisue commented Feb 11, 2020

Has anyone looked into the actual bug?

it regressed between 2.13.0-M1 and 2.13.0-M2 and not much else was merged for M2 besides scala/scala#5903 at which Adriaan writes:

Known (temporary) regressions in this PR:

  • lost syntax highlighting because it was done in the compiler, while it should be in the shell (UI)

so, apparently a refactoring casualty rather than a “bug” per se

@som-snytt
Copy link

som-snytt commented Feb 11, 2020

Let's first get the jline3 upgrade merged and then see about this.

Obviously Adriaan jinxed it.

@SethTisue
Copy link
Member

lost syntax highlighting

note that "syntax highlighting" is a rather exalted way of describing what was lost here. res0 is one color and Seq[Int] is another color, that's all it is.

@som-snytt
Copy link

The release notes will highlight the lost syntax.

@dwijnand
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants