Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.12.3 #404

Closed
36 of 37 tasks
retronym opened this issue Jul 7, 2017 · 16 comments
Closed
36 of 37 tasks

Release 2.12.3 #404

retronym opened this issue Jul 7, 2017 · 16 comments
Assignees

Comments

@retronym
Copy link
Member

retronym commented Jul 7, 2017

Milestone: https://github.com/scala/scala/milestone/61

Target date: July 17

Before the release

  • Notify community on https://contributors.scala-lang.org/c/announcements
  • Create next milestone, move the "Merge to 2.13.x" description to it (default for new PRs)
  • Close the milestone
  • Triage scala/bug and scala/scala-dev tickets that target [version]
  • Check PRs assigned to the milestone, also check WIP
  • Check merged PRs for the next milestone in this branch, and assign them to this milestone.
  • Check module versioning
  • Merge in older release branch

Release notes

Actual release

  • Announce start of release process, point to release note PRs for feedback
  • Close the scala/bug milestone, create next, move pending issues
  • Close the scala-dev milestone, create next, move pending issues
  • Double check version.properties, maybe create a PR with updates

Stage the release

Point of no return

  • Push scala/scala tag: git push https://github.com/scala/scala.git v[version]
  • Before the next nightly, advance HEAD on scala/scala past the tag. Otherwise, the nightly build will re-stage the release and overwrite the distribution archives on S3. TODO: should we disable this? Tag driven distribution publication was disabled in Disable tag driven publication of distribution scala#5979
  • Push scala/scala-dist tag: git push https://github.com/scala/scala-dist.git v[version]
  • Promote staging repos: st_stagingRepoPromote [scala-repo], st_stagingRepoPromote [modules-repo]

Check availability

When everything is on maven central

Announcements

@retronym retronym self-assigned this Jul 7, 2017
@retronym
Copy link
Member Author

retronym commented Jul 7, 2017

Pre-announce draft:

2.12.3

Highlights:

2.13.0-M2

The REPL is undergoing renovations and features better positioning of errors and a cleaner internal implementation. multi-line editing and syntax highlighting.

Right associative methods with a by-name parameter no longer eagerly evaluate the operand.

Furthermore, all changes in the 2.12.3 will be part of 2.13.0-M2.

What's next?

We are planning to make 2.13.x the default branch for pull requests after these releases to help us focus our collective attention on working towards 2.13.0. We'll still target some changes to 2.12.x that are high reward and low risk, that fix important regressions.

@xeno-by
Copy link

xeno-by commented Jul 7, 2017

Compiler performance has been improved significantly

Omg hype!! Can't wait for the release date. 💖

@som-snytt
Copy link

call me hyped. My favorite part is "point of no return". Do I need a bungie cord?

@retronym
Copy link
Member Author

retronym commented Jul 8, 2017

"point of no return" sounds like the next SIP-18 language flag.

@retronym
Copy link
Member Author

retronym commented Jul 25, 2017

The release build for 2.12.3 failed with:

[info] :: delivering :: org.scala-lang#junit;2.12.3 :: 2.12.3 :: release :: Mon Jul 24 08:37:49 UTC 2017
[info] 	delivering ivy file to /home/jenkins/workspace/scala-2.12.x-integrate-bootstrap/target/junit/ivy-2.12.3.xml
java.io.IOException: PUT operation to URL https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scala-lang/scala-library-all/2.12.3/scala-library-all-2.12.3.pom failed with status code 504: GATEWAY_TIMEOUT
	at org.apache.ivy.util.url.AbstractURLHandler.validatePutStatusCode(AbstractURLHandler.java:82)
	at org.apache.ivy.util.url.BasicURLHandler.upload(BasicURLHandler.java:264)
	at org.apache.ivy.util.FileUtil.copy(FileUtil.java:150)
	at org.apache.ivy.plugins.repository.url.URLRepository.put(URLRepository.java:84)

In any case, we had one extra PR to add to the release, scala/scala#6004, so we'll need to re-run anyway.

However, the subsequent nightly build failed with: #409 which I'll have to look at first.

Optimistically kicking off the release build while I investigate: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-release-main/876/console

@retronym
Copy link
Member Author

#409 is a latent bug, let the release roll on.

@lrytz
Copy link
Member

lrytz commented Jul 25, 2017

#409 hit again on the next attempt (https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-bootstrap/1042/consoleFull)

[info] ! type deconstruction.tuple type (3): Exception raised on property evaluation.
[info] > Exception: java.lang.IllegalArgumentException: requirement failed: Tuples with 3 arity aren't supported

Starting another one... https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-release-main/878/

@retronym
Copy link
Member Author

retronym commented Jul 25, 2017 via email

@lrytz
Copy link
Member

lrytz commented Jul 25, 2017

Yeah - at least the build passed now. https://scala-ci.typesafe.com/job/scala-2.12.x-release-main/878/ I'll announce the staging tomorrow (if nobody does it before).

@retronym
Copy link
Member Author

I've announced the staged release.

@jvican
Copy link
Member

jvican commented Jul 26, 2017

I have just compiled Zinc with 2.12.3. Everything's good on my end.

@xeno-by
Copy link

xeno-by commented Jul 26, 2017

For those who'll want to try out the 2.12.3 prerelease, here are the required changes to your sbt builds: https://github.com/scalamacros/paradise/blob/2c7f071ecd1d0e75b678fbdc81fc0e6e80042edf/project/build.scala#L6-L7.

@DavidGregory084
Copy link

resolvers += Resolver.sonatypeRepo("staging") also works

@jvican
Copy link
Member

jvican commented Jul 28, 2017

We've noticed a 23% improvement in the overall sbt codebase: sbt/sbt#3383 (comment).

Are there any results about improvements in the scala/scala codebase? Have you already bumped to 2.12.3?

@SethTisue
Copy link
Member

SethTisue commented Jul 28, 2017

Have you already bumped to 2.12.3?

yes, scala/scala#6011

Are there any results about improvements in the scala/scala codebase?

http://developer.lightbend.com/blog/2017-06-12-faster-scala-compiler/ has that number (0.85x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants