Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recent 2.13.x broke SerializationStabilityTest in scala-parallel-collections #809

Closed
SethTisue opened this issue May 13, 2022 · 5 comments · Fixed by scala/scala-parallel-collections#220
Assignees
Milestone

Comments

@SethTisue
Copy link
Member

this came up over at scala/community-build#1564 which changes the Scala 2.13 SHA from scala/scala@3ed3e3f to scala/scala@e623b15

https://scala-ci.typesafe.com/job/scala-2.13.x-jdk11-integrate-community-build/3693/artifact/logs/scala-parallel-collections-build.log shows

[scala-parallel-collections] [info] Test scala.SerializationStabilityTest.testAll started
[scala-parallel-collections] [error] Test scala.SerializationStabilityTest.testAll failed: java.io.InvalidClassException: scala.collection.immutable.OldHashMap; local class incompatible: stream classdesc serialVersionUID = -2425602972438308285, local class serialVersionUID = -6733093582541111701, took 0.125 sec
[scala-parallel-collections] [error]     at java.io.ObjectStreamClass.initNonProxy(ObjectStreamClass.java:689)
@SethTisue SethTisue added this to the 2.13.9 milestone May 13, 2022
@SethTisue
Copy link
Member Author

ohhhh... presumably this an expected consequence of scala/scala#9976 and I just need to update the test

fyi @lrytz

@lrytz
Copy link
Member

lrytz commented May 13, 2022

Mhm.. It means there are some serializable classes that don't define an explicit @SerialVersionUID. The correct fix would be to find those classes, see their computed SVUIDs (when using 2.13.8), and add an annotation with that specific value. This is what I did in the PR (first commit, scala/scala@003dc97).

@SethTisue
Copy link
Member Author

oh okay, I'll do that.

@SethTisue
Copy link
Member Author

@SethTisue
Copy link
Member Author

SethTisue commented May 18, 2022

[info] Report from the dbuild run for dbuild: 
...
[info] Project scala-parallel-collections--: SUCCESS (project rebuilt ok)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants