Track import selector of implicit info in search #10645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
issue/12690-import-commit
branch
from
0081d78
to
66a1988
Compare
som-snytt
force-pushed
the
issue/12690-import-commit
branch
from
66a1988
to
5dd1135
Compare
som-snytt
force-pushed
the
issue/12690-import-commit
branch
from
5dd1135
to
5532ca5
Compare
|
The build error was not an obscure false positive; a few files pick up strip margin interpolator via |
lrytz
approved these changes
Jan 15, 2024
| val res = typedImplicit(firstPending, ptChecked = true, isLocalToCallsite) | ||
| if (res.isFailure) res | ||
| else | ||
| new SearchResult(res.tree, res.subst, res.undetparams, firstPending) |
There was a problem hiding this comment.
OK, I see it's simpler to register the ImplicitInfo here 👍
|
As hinted on the ticket, I see from a stale branch that work began at that time. I say, "at that time", yet what is time, but a vapor? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For recording when import selectors have been "used", record selector only after successful implicit search; for other look-ups, avoid recording during implicit search.
Fixes scala/bug#12690