Namers - no duplicates: backport changes to avoid allocations [nomerge] #7820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We "backport", but with some changes, the improvements to the `noDuplicates` function already introduced in the 2.13.x branch. Importantly, this avoids the allocation of two mapped lists.
diesalbla
changed the title
diesalbla
commented
Mar 6, 2019
| selectors foreach checkSelector | ||
|
|
||
| def noDuplicates(): Unit = { | ||
| @inline def isRename(hd: ImportSelector): Boolean = |
There was a problem hiding this comment.
In 2.13.x, this is a method of the ImportSelector class, but I do not want to change any API in 2.12.x.
retronym
added
the
performance
diesalbla
changed the title
retronym
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks up from #7811
We backport to 2.12.x some changes from the PR #6218, on the code to detect duplicates in the import selectors. These changes help us to avoid allocating two extra lists due to the use of the
mapfunctions.