[nomerge] Emit warnings in the REPL #9298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I only kind of remember tweaks around REPL "parse errors" vs "typer errors in wrapped/templated code". Probably I never got over that my "repl plugin" thing never made it, where you just submit the template once and pick up your trees at the end of the run. |
7 tasks
I guess you mean #2984 (comment)? |
dwijnand
force-pushed
the
2.12/repl-summarizes-warnings
branch
from
4aa2ea6
to
4a7d02e
Compare
dwijnand
force-pushed
the
2.12/repl-summarizes-warnings
branch
from
4a7d02e
to
0ae0739
Compare
dwijnand
added
the
prio:blocker
|
This improves the status quo, fixing the REPL warning issue that Zinc's tests revealed in the 2.12 CB. So I'm going to merge on that basis - but I'm happy to follow-up on any feedback given post-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to backport #7756, but it doesn't fix the tests. (I hand-rolled their checkfiles so don't take them as canon.)
@som-snytt I think I'm right in thinking that you aren't that interested in sinking time in 2.12's REPL. But in the interest of getting 2.12 and 2.13 released, could you spend a second seeing if you can see what's missing to fix this? It might be a blocker for the 2.12 release...