Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Scala 3 star in import braces #9639

Merged
merged 1 commit into from
May 21, 2021
Merged

Conversation

som-snytt
Copy link
Contributor

Just a tweak. As reported on gitter.

@scala-jenkins scala-jenkins added this to the 2.13.7 milestone May 20, 2021
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a second I thought it said "Wildcard import cannot be tamed".

Thanks for the quickfix!

@lrytz lrytz merged commit 3b1b2d1 into scala:2.13.x May 21, 2021
@som-snytt som-snytt deleted the issue/tweak-star branch May 21, 2021 06:32
@smarter
Copy link
Member

smarter commented Jun 10, 2021

This PR should be backported to 2.12 since it fixes an issue introduced by a commit that was also backported to 2.12 (#9589). Is there a label or something that can be applied to this PR to make sure this isn't forgotten?

@som-snytt
Copy link
Contributor Author

I will back-tweak. I happen to be wearing my "Wildcard imports can't be tamed" t-shirt.

@som-snytt
Copy link
Contributor Author

OK, it's getting sbt 1.3.13...

@som-snytt
Copy link
Contributor Author

It's not a back-twitch because on 2.12

scala> object X { def f = 42 }
defined object X

scala> { import X.{_ => g} ; f }
res1: Int = 42

@som-snytt
Copy link
Contributor Author

#9665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants