-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Eq
instances into scala.Eq companion object?
#2698
Comments
I think we could well move them to the companion object. Who wants to try that? Happy to review a PR. |
To be sure: I can't volunteer to send PRs till I graduate. |
Downside of moving the instances: they can't be disabled. EDIT: to be clear, I think |
Fix #2698: Move eqXYZ instances to Eq
Discussion after https://www.reddit.com/r/programming/comments/6elim6/announcing_dotty_012rc1_a_major_step_towards/ points out that the extra implicit instances of
Eq
infect the global namespace and that's undesirable — those instances are currently available for autocompletion when typinge
.Could one move them to
Eq
's companion object?That might require using a different object as default instance, and maybe patching compiler special cases—such changes are included in the scope of this issue.
The text was updated successfully, but these errors were encountered: