Refine GADT casts on singletons #12159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- keep the singleton type in the cast target - assert cast target stability if original was stable - fix isStable test for TypeParamRefs - double check if GADT logic is really needed before inserting a cast Fixes scala#11220 Fixes scala#11955
|
It seems that the warning about unnecessary GADTused was printed always when performing the check, not only when the flag was actually unnecessary. I fixed that and it seems we don't get that many warnings in the test suite. I tried to write a test for the Stable annot. It seems that it's added in a lot of GADT tests, but none of those are necessary. I'd need to inspect what exactly -Ycheck is doing that requires the Stable annot and I'm not sure if that's the wisest use of my time, I think I'm just going to trust you Martin that this code is necessary. |
|
@odersky can you approve this PR so it can be merged? |
|
Noice! Thanks @abgruszecki ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11987.
Fixes #11220
Fixes #11955