Add spire to community build #13788
Merged
Add spire to community build #13788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by #13860. |
|
Green! Can someone kindly help get this merged, before there is another regression? 😆 |
prolativ
approved these changes
Nov 18, 2021
.gitmodules
Outdated
| @@ -216,3 +216,6 @@ | |||
| [submodule "community-build/community-projects/specs2"] | |||
| path = community-build/community-projects/specs2 | |||
| url = https://github.com/dotty-staging/specs2.git | |||
| [submodule "community-build/community-projects/spire"] | |||
| path = community-build/community-projects/spire | |||
| url = https://github.com/typelevel/spire.git | |||
There was a problem hiding this comment.
Suggested change
| url = https://github.com/typelevel/spire.git | |
| url = https://github.com/dotty-staging/spire.git |
As a rule we use links to forks instead of original repos to ensure reproducibility of builds from the compiler's perspective (if the main branch of the community project repo changes, possibly making the community build fail, but the compiler's master doesn't change then master's build should still succeed if it succeeded earlier).
I created the fork so this should work with the suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We finally ported it to Scala 3 :)
https://github.com/typelevel/spire/releases/tag/v0.18.0-M1