Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asm to 9.4 #16155

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Update asm to 9.4 #16155

merged 1 commit into from
Nov 1, 2022

Conversation

Philippus
Copy link
Member

@Philippus Philippus commented Oct 8, 2022

There's first some work to be done in https://github.com/scala/scala-asm.

scala 2.12.x PR: scala/scala#10185
scala 2.13.x PR: scala/scala#10184

@SethTisue
Copy link
Member

This seems like a candidate for backporting to 3.2.x.

I will do the work in the scala-asm repo, but not right away (vacation/travel). Unless @lrytz beats me to it :-)

@SethTisue SethTisue assigned SethTisue and unassigned Philippus Nov 1, 2022
@SethTisue SethTisue added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Nov 1, 2022
@SethTisue SethTisue marked this pull request as draft November 1, 2022 14:18
@SethTisue
Copy link
Member

marking as draft for now (perhaps over-cautiously) until the corresponding Scala 2 PRs have passed CI and been merged

@SethTisue SethTisue marked this pull request as ready for review November 1, 2022 18:27
@SethTisue
Copy link
Member

Okay, the Scala 2 PRs are merged.

@SethTisue SethTisue assigned smarter and unassigned SethTisue Nov 1, 2022
@smarter smarter merged commit d84007c into scala:main Nov 1, 2022
@Philippus Philippus deleted the update/asm-9.4 branch November 1, 2022 18:56
@SethTisue
Copy link
Member

@Kordyjan could this make 3.2.2? (or 3.2.3?)

@Kordyjan
Copy link
Contributor

Kordyjan commented Nov 3, 2022

It can make 3.2.2-RC2 (which we will need), so no need to worry.
And as a note, we have decided that there will be no 3.2.3 and we are going for 3.3. Hopefully, we will be able to announce later (probably around 3.3.1 or 3.3.2) that 3.3 is an LTS version.

@Kordyjan Kordyjan assigned Kordyjan and unassigned smarter Nov 3, 2022
@smarter
Copy link
Member

smarter commented Nov 3, 2022

In theory we should only backport things which fix regression, does this fix any regression?

@SethTisue
Copy link
Member

SethTisue commented Nov 3, 2022

No, no regression per se, unless you want to get slippery and say that “supports latest JDK” regressed (because the “latest JDK” pointer moved). I’d of course accept a ruling on that grounds, but I’m not sure it’s necessary to be so strict.

One’s feelings might depend on whether one’s crystal ball predicts that 3.3 is really coming soon or whether there’s a chance of it slipping for as long as 3.2 did.

@smarter
Copy link
Member

smarter commented Nov 14, 2022

“supports latest JDK” regressed

But we don't need to upgrade asm to support using the latest JDK, it's only needed for the -target/-release/... flags to emit bytecode that won't be loaded by previous JDK releases, so I don't think it's a big deal. Especially in this case where we're adding support for JDK 20 which won't be released until March 2023.

@lrytz
Copy link
Member

lrytz commented Nov 15, 2022

Right. Scala 2 uses ASM to read classfiles (optimizer, build pipelining), but that's not the case here.

@SethTisue SethTisue removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Nov 15, 2022
@Kordyjan Kordyjan removed their assignment Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants