Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Set baseVersion to 3.5.1-RC1" #20402

Merged
merged 1 commit into from
May 14, 2024

Conversation

hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented May 14, 2024

Reverts #20392

Closes #20401

@odersky
Copy link
Contributor

odersky commented May 14, 2024

I believe Mima filters need to be updated for the new base version.

@hamzaremmal
Copy link
Member Author

I believe Mima filters need to be updated for the new base version.

Yes, but 3.5.0-RC1 is not yet in Maven Central. I've reverted the PR as a hot fix and remerge it with the new base version when 3.5.0-RC1 is in Maven Central

@Kordyjan
Copy link
Contributor

This is a matter of MiMa's known bug/weird behavior: It treats 3.4.1 => 3.5.0-RC1 as a minor version bump, but 3.4.1 => 3.5.1-RC1 as a patch version bump and reports errors on forward incompatibilities. What I didn't expect was that it auto-merged my PR even though MiMa checks were failing. I was nearly sure that they were required.

I don't get what it has to do with 3.5.0-RC1 being on Maven Central or not. 3.5.1-RC1 is a version that is in development, so it should be set as a base version.

@hamzaremmal
Copy link
Member Author

If 3.5.0-RC1 is available, we can do the following change to satisfy MiMA.

@hamzaremmal
Copy link
Member Author

What I didn't expect was that it auto-merged my PR even though MiMa checks were failing. I was nearly sure that they were required.

MiMA checks is not a requirement that we enforce for a PR for now. I've asked @Gedochao to add this to tomorrow's core meeting agenda to have a final decision on adding it as a requirement. #20392 is a good argument to make it a requirement.

Copy link
Contributor

@Kordyjan Kordyjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was convicned that it is currently the best solution.

@Kordyjan Kordyjan merged commit 4dffcc9 into main May 14, 2024
37 checks passed
@Kordyjan Kordyjan deleted the revert-20392-base-version-3.5.1-RC1 branch May 14, 2024 10:57
@hamzaremmal
Copy link
Member Author

Now that 3.5.0-RC1 is in Maven Central, we can apply the correct fix #20404

hamzaremmal added a commit that referenced this pull request May 15, 2024
This depends on 3.5.0-RC1 being released to Maven Central

Part of #20402
@bishabosha
Copy link
Member

@hamzaremmal now can we unrevert this?

@hamzaremmal
Copy link
Member Author

hamzaremmal commented May 21, 2024

I thought I did in #20404. I've opened a PR for that (#20447)

hamzaremmal added a commit that referenced this pull request May 21, 2024
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly Dotty workflow of 2024-05-14 failed
4 participants