Fix declaring product of straight-to-jar compilation #20592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpi2
commented
Jun 18, 2024
adpi2
commented
Jun 19, 2024
| def close(): Unit = this.synchronized(jpath.getFileSystem().close()) | ||
| override def exists: Boolean = jpath.getFileSystem().isOpen() && super.exists | ||
| def allFileNames(): Iterator[String] = | ||
| java.nio.file.Files.walk(jpath).iterator().asScala.map(_.toString) | ||
|
|
||
| override def toString: String = jarPath.toString |
There was a problem hiding this comment.
It used to print / (the root path inside the JAR) instead of /path/to/file.jar
It returns the absolute path of the jar file instead of '/'
adpi2
force-pushed
the
fix-inc-compilation-on-jar
branch
from
1f07142
to
e0b7001
Compare
|
@jamie For a class file in a JAR, I returned the |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the straight-to-JAR compilation does not declare any class file to Zinc, which prevents Zinc from compiling downstream modules incrementally.
For the context, we would like to enable straight-to-JAR compilation in sbt 2.x, and put remote caching on top of it.