Give to @odersky. #2439
Closed
Give to @odersky. #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies need to have same receiver :-)
They may have side-effects, unlike reading other arguments.
Will get back to it later.
Disabled it because it makes trees not similar
@DarkDimius this is what I remember from our conversation yesterday. Could you check that I got the valify/devalify/varify right? It's mostly a brain dump from what you explained, I didn't spent too much time trying to reverse engineer the code. I also took the liberty to reformat a few things (such as { (ctx0: Context) => { implicit val ctx: Context = ctx0 <body> } }), I hope these are improvement.
The bug happened for `new Tuple2[Int, Int](1, 2)._1`, if the last `._1` selection is done by symbol. This will create a uniqueRefDenotation with underlying type Int. This denotation has to be erased in conformance with underlying type, not with the observed type before erasure, as otherwise you'd think that `_1` on topple returns Int.
This one has no checking and does not assume anything about how labels work. But if labels are generated wrong, it does not try to fix it or warn about it. In case labels are wrong - now you'll get a crash in backend. -- Manually cherry picked from dotty-linker@11e7808
LabelDefs phase now may move labels into other labels if this is the right location to emmig the go-to. This may break scoping rules. Possible solution was to disable Ycheck, but as there are other tricky phases now in the same phase block, I preferred to teach Ycheck to lift more restrictions on LabelDefs. Ycheck already knew something about LabelDefs, as it used to break ownership links for go-tos, but not it also breaks scoping rules. Demonstrated by tests/run/t1333.scala Thanks @OlivierBlanvillain for nice minimization.
The test suite fails on master with -optimise without this change
The situation is a follows: Without this commit `testOnly dotty.tools.dotc.CompilationTests -- *testPickling` fail with more precise types after pickling. Reverting tpd.scala to master breaks the "tree referencial equiality" condition used in Simplify to detect a fix point. For example `vulpix t7336.scala` (this one also requires the Skolem#toString change). This hack is sufficent for Simplify to reach its fix points without breaking pickling...
This test: sbt "run -optimise -Ycheck:tailrec,resolveSuper,mixin,restoreScopes,labelDef,simplify tests/pos/t7126.scala" Breaks with the tpd changes alone. By that I mean even when disabling all optimisation (this commit), t7126 still fails.
This also seems to be a reason why Ycheck:front fails. typeAssigner is REMOVING partial evaluation that typer did when you copy a tree. It means that types would be different if you test pickling. Temporary(permanent) solution: don't print constant types in pickling.
dottybot
reviewed
May 16, 2017
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Added" instead of "Add")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
|
@DarkDimius @OlivierBlanvillain I verified that the original problem is fixed with the latest commit. |
|
I was trying first to avoid a kind-polymorphic Nothing but ran into several other problems. See 9b022ab in branch wip-hk-bottom on staging. So for now this is a quick fix of the problem you were seeing. |
|
@odersky, thanks for the fix! |
OlivierBlanvillain
added a commit
to dotty-staging/dotty
that referenced
this pull request
May 23, 2017
This is the issue discussed on scala#2439. The fix implemented there (6f3aa3c) breaks a bunch of other tests; to be further investigated.
OlivierBlanvillain
added a commit
to dotty-staging/dotty
that referenced
this pull request
May 29, 2017
This is the issue discussed on scala#2439. The fix implemented there (6f3aa3c) breaks a bunch of other tests; to be further investigated.
DarkDimius
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
May 29, 2017
This is the issue discussed on scala#2439. The fix implemented there (6f3aa3c) breaks a bunch of other tests; to be further investigated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @odersky.
Reproduction of inference problem:
Currently it infers a Nothing as a CC[T] to be Nothing[T], and isn't able to figure out that
Nothing[Any] =:= Nothing
We've had a discussion that it should isntead infer CC[T] to be type lambda T => Nothing to be kind-correct.