Fix positions of enum cases #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably still not 100% correct, but makes enum basically usable in the IDE (go to definition works inside an enum now)
odersky
reviewed
Jun 10, 2017
| val vdef = ValDef(name, TypeTree(), New(impl1)).withMods(mods | Final).withPos(pos) | ||
| flatTree(scaffolding ::: vdef :: Nil).withPos(pos.startPos) | ||
| val vdef = ValDef(name, TypeTree(), New(impl1)).withMods(mods | Final) | ||
| flatTree(scaffolding ::: vdef :: Nil).withPos(pos) |
There was a problem hiding this comment.
Can you add an explanation how that makes a difference? I thought that the previous version would give pos to the actual value definition and startPos to scaffolding. Isn't that what we want?
There was a problem hiding this comment.
The previous version called withPos(pos.startPos) on the whole tree, since children positions have to be contained inside their parents positions, this means that the whole tree including vdef got position pos.startPos.
There was a problem hiding this comment.
Ah I see now. There are some subtleties involved here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably still not 100% correct, but makes enum basically usable
in the IDE (go to definition works inside an enum now)