Remove Bench or A generic JHM benchmark interface #2884
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
bench/
project is no longer necessary, as it's superseded by:Web UI: https://liufengyun.github.io/bench/
We can either remove the project
bench
completely, or change it in to a generic test interface, as this PR does. This PR will enable developers to run jmh benchmarks in command line:sbt dotty-bench/jmh:compile sbt dotty-bench/pack bench/target/pack/bin/bench hello.scala # arguments are the same as compiler options
Note: The separation of benchmarking into a separate repo is justified by the fact that (1) we need to test history of Dotty, thus the test driver has to be independent of versions of Dotty; (2) Dotty doesn't depend on it; (3) faster development process.