Fix #4030: avoid adding duplicate binders #4034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blaisorblade
suggested changes
Feb 23, 2018
tests/pos/i4030.scala
Outdated
| sealed trait Root[T] | ||
| case object C1 extends Root[Int] | ||
| case object C2 extends Root[String] | ||
| //case class C3[X, Y]() extends Root[X|Y|(X => X)] |
There was a problem hiding this comment.
Let’s drop the comments I guess...
There was a problem hiding this comment.
All comments removed.
tests/pos/i4030.scala
Outdated
| def f[A <: Seq[_], B, Foo >: A => B](v: Root[Foo], u: Root[Foo]) = (v, u) match { | ||
| //case C1 => | ||
| //case C2 => | ||
| case (C3(), C3()) => |
There was a problem hiding this comment.
Sorry, shouldn’t there be a checkfile for the exhaustivity warning triggered by this code?
There was a problem hiding this comment.
I moved the test to be a patmat test and added a check file. For pos/neg tests, we don't have check files.
Blaisorblade
approved these changes
Feb 23, 2018
| case _ => | ||
| unapp | ||
| def addBinders(unapp: Tree, bound: List[Symbol]) = { | ||
| var remain = bound.toSet |
There was a problem hiding this comment.
Move this in case TypeApply(fn, args) =>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4030: avoid adding duplicate binders