Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4713: Fixing sidebar auto-collapse issue #5654

Merged
merged 1 commit into from
Dec 25, 2018
Merged

Fix #4713: Fixing sidebar auto-collapse issue #5654

merged 1 commit into from
Dec 25, 2018

Conversation

duanebester
Copy link
Contributor

Adding files in correct folders makes the navigation happy.

(Have signed the CLA)

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@duanebester duanebester changed the title Issue 4713: Fixing sidebar auto-collapse issue. Fix #4713: Fixing sidebar auto-collapse issue Dec 21, 2018
@duanebester duanebester reopened this Dec 25, 2018
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! But could you add "Fix #4713" in the body of the commit message ? That way the issue will be automatically closed when we merge this PR.

@duanebester
Copy link
Contributor Author

@smarter added, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants