STOP THE PRESS - Fix privateWithin printing #6642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
0.16.0-RC1 is already in the Maven... Will force-pushing 0.16.0-RC1 tag again overwrite the maven artefacts? Will we need to remove the automatically created release from github releases? |
|
@smarter would you know the answer? |
|
It's not possible to overwrite maven artifacts, we'd need to publish an RC2 if we consider this critical enough. |
|
I can rebase 0.16.x on top of |
|
I believe it is critical. The problem is that right now, private def f ...prints private[<none>] def f ...That's not good for a first impression. |
|
Yes that's fine |
|
Though you should merge master into 0.16.x, not rebase which would rewrite the public history |
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jun 9, 2019
The issue in scala#6642 shows that errors may be latent in seemingly simple fixes if not tested, which can backlash us at critical moment.
Merged
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jun 9, 2019
The issue in scala#6642 shows that errors may be latent in seemingly simple fixes if not tested, which can backlash us at critical moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts:
Fix #620: show privateWithin in tree printing (reverted from commit 8a7e01e)
The previous fix messed up printing of all private definitions that did not have a privateWithin.
We need to wait with the 0.16 release until this is merged.
Also, it would be good to add tests. I verified interactively that it does the right thing now, but am out of time to write a proper test.