Safe initialization for Scala #7789
Merged
Commits on Feb 13, 2020
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Class parameters are always initialized before parent constructor calls and class body fields.
-
-
-
Handle A & B for this via self type
We need to keep all components, as in asSeenFrom all will become empty except the class that contains the code for `this`.
-
Previous code gets the constructor symbol instead of the class symbol.
-
In case of local class, the outer is the enclosing class. In checking a class, no need to check args in parent calls, as they are hot. Checking them is subtle, as access of class params are final instead of virtual. Meanwhile, posttyper generates confusing accessor: ``` abstract class Base(val x: Int) class C(x: Int) extends Base(x) ``` After posttyper: ``` abstract class Base(val x: Int) class C(x: Int) extends Base(C.this.x) { private def x: Int = super.x } ``` The accessor `def x: Int = super.x` makes it subtle to give semantics to `Base(C.this.x)`. -
-
-
-
-
-
-
-
-
Fix missed effects in new-expressions
All inner-outer tests are green
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Promote is more semantically correct than Leak: leaking means something bad, but promotion is neutral or positive. A warning may be reported if the promotion is unsafe.
-
-
-
-
-
-
-
-
-
-
-
-
Fix exception: not all traits have constructors
ErasedFunctionX does not have constructors, thus no need to follow. dotc -d out -Yerased-terms -Ycheck-init tests/run-custom-args/erased/erased-15.scala
-
Fix exception: Any and AnyVal don't have constructors
dotc -d out -Ycheck-init tests/run/vc-equals.scala
-
The method name is not an invariant: dotc -d out -Ycheck-init tests/pos/i4350.scala
-
Fix crash: SuperType.supertpe can be AndType
dotc -d out -Ycheck-init tests/pos/SI-4012-b.scala
-
Fix crash: polymorphic function apply does not have symbols
dotc -d out -Ycheck-init tests/run/polymorphic-functions.scala
-
Fix crash: handle annotations in parents
dotc -d out -Ycheck-init tests/pos/annot.scala
-
-
It should return a tuple of effects and potentials due to length limit. Previously, the effects are checked but the errors are thrown away.
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.