Fix #7843: Move LiftTry back to before CapturedVars #7846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to lift tries before going into CapturedVars since a lifted try might cause a var to be captured. This means LazyVals now runs after LiftTry, so we have to account in LiftTry for the fact that the RHS of a lazy val needs its tries to be lifted.
smarter
approved these changes
Dec 24, 2019
There was a problem hiding this comment.
LGTM, but #7356 should be closed too, and maybe we should add a comment to indicate that a different scheme for lazy vals would not require this lifting as #7356 (comment) mention.
Add reference to alternate implementation scheme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to lift tries before going into CapturedVars since a lifted try
might cause a var to be captured. This means LazyVals now runs after LiftTry,
so we have to account in LiftTry for the fact that the RHS of a lazy val
needs its tries to be lifted.
Fix #7356