bugfix: Export runtime jars correctly from sbt #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like tests are discovered from runtime classpath and the changes break things. Will take a look tomorrow. |
tgodzik
force-pushed
the
add-runtime
branch
2 times, most recently
from
405b94f
to
f67df04
Compare
adpi2
approved these changes
Nov 20, 2023
integrations/sbt-bloop/src/main/scala/bloop/integrations/sbt/SbtBloop.scala
Outdated
Show resolved
Hide resolved
integrations/sbt-bloop/src/sbt-test/sbt-bloop/runtime-dependency/build.sbt
Outdated
Show resolved
Hide resolved
Previously, we would not save runtime jars which could lead to users not being able to run their programs. Now, we export runtime classpath properly from sbt. Related to scalacenter#1606 though I want to check out if it will also work via DAP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would not save runtime jars which could lead to users not being able to run their programs.
Now, we export runtime classpath properly from sbt.
Related to #1606 though I want to check out if it will also work via DAP