Fix migration warnings in scio-core #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh no... Seems like some dependencies are using bintray, which is shutting down. Seems like dependencies have been somewhat updated on |
vincenzobaz
approved these changes
Apr 14, 2021
MaximeKjaer
force-pushed
the
scala3-main
branch
from
c72310d
to
7306569
Compare
MaximeKjaer
force-pushed
the
fix-scio-core-migration-warnings
branch
from
c52a2f5
to
461f66a
Compare
|
Thank you, this is a good point. Where possible, I've made the private scope of constructors more specific. |
|
If tests pass, I suggest we squash and merge. |
MaximeKjaer
added a commit
that referenced
this pull request
Apr 19, 2021
MaximeKjaer
added a commit
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like it's necessary to not be in migration mode in order to use the new Scala 3
givenkeyword. In order to be able to use this, I've fixed the migration warnings inscio-core, and have removed the migration mode.I used the
-rewriteoption to help me fix some warnings. For the do-while, I preferred to rewrite it using avarrather than the recommended style, which I somewhat illegible...