Skip to content

Styled tags #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 3, 2017
Merged

Styled tags #3

merged 3 commits into from
May 3, 2017

Conversation

cuzfrog
Copy link
Contributor

@cuzfrog cuzfrog commented May 3, 2017

This push solves problems as we previously discussed:

  1. Bypass DOMProps which has js function field problem: val/var fields should be typed as js.Function(N) to make them recognized by node/browser. scala-js/scala-js#2922
  2. Give full agility to dom tags. Without huge source files, new styled tags use object attributes as variable parameters.
  3. Suppress Intellij IDEA highlighting error, while making sense to sbt. It uses an implicit function to do the conversion, which is stripped off by macro.
  4. Add almost no performance penalty. Code is generated by macros, directly passed to CreateDOMElement.

I have setup development environment as sub-projects in vdom. Put styled tags under package sri.web.vdom.styled, and give a quick reference styledtags under package sri.web .

See commit messages for more info.

Cause Chung added 3 commits May 1, 2017 17:37
Setup devolopment build environment.
69d7878
Implement new style tags with macros.
bd10457 
  1. */macros/ macros and updated tags, attributes.
  2. project/  update development environment and src gen tasks.
  3. /web/template/ tests.
Integrate styled tags.
9c5eccc 
  1. Move styled tags to package sri.web.vdom.styled.
  2. Update build dependency: add scala-reflect due to macros.
  3. Update README.md.
@cuzfrog cuzfrog merged commit b9a2347 into scalajs-react-interface:master May 3, 2017
@cuzfrog cuzfrog deleted the styled-tags branch May 3, 2017 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cuzfrog