Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer the metals VSCode extension to run in the "Workspace" as opposed to "UI" #1515

Merged
merged 2 commits into from
May 30, 2024

Conversation

Quafadas
Copy link
Contributor

I've been experimenting with using metals in codespaces.

Under certain conditions (e.g. firewalls), I believe the metals extension may struggle to communicate with it's build server if running in the on the UI side of the architecture.

This change says "I prefer to run in the workspace (i..e next to the code, and where the build server also wants to be), but I can run on the UI side if you want me to". I think metals might also work in the UI under this architecture under permissive network conditions, so I have't chosen to prevent the UI side entirely.

I've had to manually set this flag a few times now, and I think it's more likely that metals will work better as a workspace extension universally, so I'm putting up for a PR as part of the extension manifest.

Here is what I believe the relevant docs are;

https://code.visualstudio.com/api/advanced-topics/remote-extensions#architecture-and-extension-kinds

https://code.visualstudio.com/api/advanced-topics/extension-host#preferred-extension-location

https://code.visualstudio.com/api/references/extension-manifest

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you just run yarn lint on packages/metals-vscode ?

@Quafadas
Copy link
Contributor Author

Thanks for the tip ... I just spent a few minutes trying to figure out prettier! Wrong starting point :-)...

change in bound.

@Quafadas
Copy link
Contributor Author

That got it 🙏

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgodzik tgodzik merged commit 671f295 into scalameta:main May 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants