Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debug isn't working after compilation error #851

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

kpodsiad
Copy link
Member

fixes #849

I was thinking about signaling the user what's going on. However, vscode notification mechanism, which is a surprise, doesn't provide an option to display a true "notification" - message which will disappear on its own after some time.

I was thinking about vscode.window.showWarningMessage("Debug didn't start because of compiler errors"); but this message stays until explicitly dismissed.

src/test-explorer/test-run-handler.ts Outdated Show resolved Hide resolved
@kpodsiad kpodsiad requested a review from tgodzik January 27, 2022 11:04
@kpodsiad kpodsiad merged commit 01c8206 into scalameta:main Jan 27, 2022
@kpodsiad kpodsiad deleted the fix-debug-after-compilation-error branch January 27, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running tests after failed compilation stops tests working
2 participants