Skip to content

Remove the ability to click on tags in docs header #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Remove the ability to click on tags in docs header #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17ad4f1
Disable links in tags
josh-wong Oct 11, 2024
241944e
Remove green outline when hovering over tags
josh-wong Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/css/custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,9 @@ a[class^='tag_'] {
color: white;
font-weight: bold;

&:hover {
/* &:hover {
border: 2px solid #78C740;
}
} */
}

html[data-theme="dark"] .badge {
Expand All @@ -150,9 +150,9 @@ html[data-theme="dark"] a[class^='tag_'] {
color: white;
font-weight: bold;

&:hover {
/* &:hover {
border: 2px solid #78C740;
}
} */
}

/* The following Font Awesome-related styles are for the question mark next to the Editions tags. These styles are currently not being used but might be useful later. */
Expand Down
4 changes: 2 additions & 2 deletions src/theme/TagsListInline/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ export default function TagsListInline({tags}: Props): JSX.Element {
</b> */}
<ul className={clsx(styles.tags, 'padding--none', 'margin-left--sm')}>
{tags.map(({label, permalink: tagPermalink}) => (
<li key={tagPermalink} className={styles.tag}>
<Tag label={label} permalink={tagPermalink} />
<li className={styles.tag}>
<Tag label={label} />
</li>
))}
</ul>
Expand Down