Update tf files for Cosmos DB #69
Conversation
|
This won't work until scalar-labs/scalar-terraform#208 is finished |
ymorimo
force-pushed
the
cosmosdb-tf
branch
from
214fd2c to
62b4a8a
Compare
| name = data.terraform_remote_state.network.outputs.network_name | ||
| dns = data.terraform_remote_state.network.outputs.dns_zone_id | ||
| id = data.terraform_remote_state.network.outputs.network_id | ||
| region = data.terraform_remote_state.network.outputs.region |
There was a problem hiding this comment.
The following may not be necessary.
cidrdnsidbastion_ipbastion_provision_idinternal_domain
There was a problem hiding this comment.
Good point! Thanks 👍
| @@ -0,0 +1,15 @@ | |||
| data "terraform_remote_state" "network" { | |||
There was a problem hiding this comment.
Do we need remote.tf.azurerm for a case where blob storage is used for the backend?
There was a problem hiding this comment.
In scalar-k8s, cassandra and monitor modules have remote.tf.azurerm (and remote.tf.s3 also), but kuberrnetes doesn't.
I wonder if these example files should be provided because they are all very similar and I think it's getting harder to keep them all correct and up-to-date. It might be better to document how to use the remote backend rather than providing example files.
There was a problem hiding this comment.
Yes, but then backend.tf.azurerm is pretty similar to other backend files.
So that's probably another issue to fix; removing redundant files.
As for this, I think it should be consistent with the others.
There was a problem hiding this comment.
In this PR, I have added remote.tf.azurerm for the cosmosdb module.
But to be fully consistent, remote.tf.azurerm (and remote.tf.s3 also?) need to be added to kubernetes module as well. That's the same for backend.tf. And monitor/remote.tf.azurerm and monitor/remote.tf.s3 already look wrong when compared to module/remote.tf. I'll fix these issues later.
BTW, basically, should we have s3 backend files in azure modules? When taking a look at scalar-terraform, it looks like modules in examples/aws have only s3 versions, but in example/azure, some modules have only azurerm versions, some have both versions, and some don't have either. I think s3 files can be removed from azure examples.
There was a problem hiding this comment.
Thanks!
I think we should remove s3 files from Azure.
So to sum up, the following needs to be fixed?
- add remote.tf.azurerm for kubenetes module
- fix monitor.tf.s3 and azurerm
- remove s3 files from azure
I think it can be done in one PR or separate PRs.
Could you?
There was a problem hiding this comment.
Thanks for the summary! Sure!
| @@ -0,0 +1,15 @@ | |||
| data "terraform_remote_state" "network" { | |||
There was a problem hiding this comment.
Thanks!
I think we should remove s3 files from Azure.
So to sum up, the following needs to be fixed?
- add remote.tf.azurerm for kubenetes module
- fix monitor.tf.s3 and azurerm
- remove s3 files from azure
I think it can be done in one PR or separate PRs.
Could you?
https://scalar-labs.atlassian.net/browse/DLT-7024