-
Notifications
You must be signed in to change notification settings - Fork 0
Add awscli role for bastion #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tei-k CI seems failed. Can you check? |
OK! Fixed in b9b9887. |
Instead of adding a flag to the Ansible command, why don't you automate it? On HVM instances, the following task would be able to tell if the current host is an EC2 instance.
|
Beause I'm not sure what's the best way. 🤔
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tei-k I'm not sure how likely it is that the method of checking an "ec2"
at the beginning of the dmidecode
output is inaccurate, but I think it's good to go with a command-line option.
I hope there is a reliable way to determine that the host is an EC2 instance.
Then, added one comment in the documentation, please take a look.
Co-authored-by: Yusuke Morimoto <yusuke.morimoto@scalar-labs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Authentication to eks cluster through the
aws eks get-token
command when using kubernetes module ofscalar-terraform
ref: scalar-labs/scalar-terraform#236
Done
Add awscli role.
How to use