Skip to content

Fix to support nvme in tuned #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 17, 2020
Merged

Fix to support nvme in tuned #207

merged 5 commits into from
Sep 17, 2020

Conversation

tei-k
Copy link
Contributor

@tei-k tei-k commented Sep 17, 2020 •
edited
Loading

Description

https://scalar-labs.atlassian.net/browse/DLT-7210

Tuned does not yet support nvme
redhat-performance/tuned#101

Done

  • Replace plugin_disk.py for support nvme disk.
  • If the plugin_disk.py file does not exist, ansible will fail. (Making it easier to notice anomalies by not confirming the existence of the file)
module.cassandra.module.cassandra_provision.null_resource.cassandra[2] (remote-exec): fatal: [10.42.2.175]: FAILED! => {"changed": false, "msg": "Path /usr/lib/python2.7/site-packages/tuned/plugins/plugin_disk.py does not exist !", "rc": 257}
  • Except nvme0n1.

@tei-k tei-k self-assigned this Sep 17, 2020
@tei-k tei-k changed the title [WIP] Fix to support nvme in tuned Fix to support nvme in tuned Sep 17, 2020
ymorimo
ymorimo previously approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@ymorimo ymorimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

feeblefakie
feeblefakie previously approved these changes Sep 17, 2020
View reviewed changes
Copy link
Collaborator

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feeblefakie feeblefakie dismissed stale reviews from ymorimo and themself via 9fdc010 September 17, 2020 04:20
@feeblefakie feeblefakie merged commit 3fe195c into master Sep 17, 2020
@feeblefakie feeblefakie deleted the fix-to-support-nvme-in-tuned branch September 17, 2020 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymorimo ymorimo ymorimo left review comments

@feeblefakie feeblefakie feeblefakie left review comments

Assignees

@tei-k tei-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tei-k @ymorimo @feeblefakie