Remove Cassandra dependencies from universal/scalardl module #232
Conversation
|
Oh, you've done this in the story !!! |
| scalardl_image_name = var.scalardl_image_name | ||
| scalardl_image_tag = var.scalardl_image_tag | ||
| internal_domain = var.internal_domain | ||
| database_contact_points = "cassandra-lb.${var.internal_domain}" # TODO: add to variables |
There was a problem hiding this comment.
If it's going to be done in another PR, can you create a story not to forget?
There was a problem hiding this comment.
Yes, the variable is going to be added later.
Created as a subtask https://scalar-labs.atlassian.net/browse/DLT-7605
For database_contact_port variable: https://scalar-labs.atlassian.net/browse/DLT-7524
|
Overall looking good. 👍 Also need to update README. |
|
@tei-k Thanks! Updated two README files. |
https://scalar-labs.atlassian.net/browse/DLT-7405
The following works have been done to remove dependencies on Cassandra from the universal/scalardl module.
(But there is no option to switch the database other than Cassandra yet.)
cassandra_usernameandcassandra_passwordhave been renamed todatabase_usernameanddatabase_password.replication_factorhas been renamed tocassandra_replication_factorsince it's going to be a Cassandra-specific option.database_contact_pointshas been added to universal/scalardl module, butcassandra-lbis still hardcoded in the aws/azure modules.database_contact_portis going to be needed but has not been added yet.The base branch of this PR is
dynamodb. I plan to open subsequent PRs toward this branch.