Add database options to aws/azure/universal scalardl modules #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `database` and `database_contact_port` variables to the universal/scalardl module
ymorimo
force-pushed
the
add-database-option-to-universal-scalardl
branch
from
8a37236 to
57dc7cc
Compare
The DynamoDB resion should be specified in `database_contact_points` instead since scalardb uses contact_points as a region.
ymorimo
force-pushed
the
add-database-option-to-universal-scalardl
branch
from
57dc7cc to
fcf2512
Compare
|
@tei-k Please take a look! |
tei-k
reviewed
Nov 24, 2020
| "%s %s", | ||
| "docker run --rm ${var.schema_loader_image} -h ${var.database_contact_points} -u ${var.database_username} -p ${var.database_password}", | ||
| var.database == "cassandra" ? "--cassandra -P ${var.database_contact_port} -n NetworkTopologyStrategy -R ${var.cassandra_replication_factor}" : | ||
| var.database == "dynamo" ? "--dynamo --region ${var.database_contact_points}" : |
There was a problem hiding this comment.
I'm not sure how it works with --region ${var.database_contact_points}. 💦
var.database_contact_points is dynamodb.${region}.amazonaws.com ?
There was a problem hiding this comment.
Good point. When DynamoDB is used, the region name should be specified in the contact_points variable.
https://github.com/scalar-labs/scalardb/blob/master/docs/getting-started-with-dynamodb.md#configure-scalar-db
This is also added in the database_contact_points variable's description. https://github.com/scalar-labs/scalar-terraform/pull/237/files#diff-c29567323bde55c7871f3e1b1fd9242c4f268d7d82129d0eb5fce499a78319d4R18
tei-k
approved these changes
Nov 24, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://scalar-labs.atlassian.net/browse/DLT-7415
Add
database,database_contact_pointsanddatabase_contact_portvariables to Terraform modules.To-Dos
The latest
scalar-ledgerimage andscalardl-schema-loaderimage don't support DynamoDB yet. Their versions should be updated to work with DynamoDB.