Skip to content

Conversation

tei-k
Copy link
Contributor

@tei-k tei-k commented Dec 1, 2020

Description

Fix to use 2.0.9 for scalardl-java-client-sdk in terratest.

ref:
#242

@tei-k tei-k requested review from ymorimo and feeblefakie December 1, 2020 08:38
@tei-k tei-k self-assigned this Dec 1, 2020
Copy link
Collaborator

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, why not 2.1.0?

@tei-k
Copy link
Contributor Author

tei-k commented Dec 2, 2020

why not 2.1.0?

Currently using version 2.0.7 for scalardl, Should we update to 2.1.0 with this PR?

blue_image_tag = "2.0.7"

@feeblefakie
Copy link
Collaborator

@tei-k Then, 2.0.9 seems more appropriate. Did you check if it works with 2.0.9?

@tei-k
Copy link
Contributor Author

tei-k commented Dec 2, 2020

@feeblefakie

Yes, I've already confirmed that it works with 2.0.9.

@feeblefakie feeblefakie merged commit 71a50b5 into master Dec 2, 2020
@feeblefakie feeblefakie deleted the fix-to-use-2.0.9-for-scalardl-java-client-sdk-in-terratest branch December 2, 2020 06:17
@feeblefakie
Copy link
Collaborator

@tei-k Thank you! Merged.

Copy link
Contributor

@ymorimo ymorimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants