Skip to content

Remove terratest #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 11, 2020
Merged

Remove terratest #249

merged 5 commits into from
Dec 11, 2020

Conversation

tei-k
Copy link
Contributor

@tei-k tei-k commented Dec 9, 2020 •
edited
Loading

Description

Migrate to scalar-terratest

Done

  • Remove terratest code.
  • Delete terratest workflow
  • Fix CI workflow.
  • Fix badge link.

After merge

Delete unnecessary secrets. (ARM_xxx, AWS_xxx, DOCKERHUB_xxx)

@tei-k tei-k self-assigned this Dec 9, 2020
@tei-k tei-k mentioned this pull request Dec 10, 2020
Merged
@tei-k tei-k requested review from feeblefakie and ymorimo December 10, 2020 06:01
@tei-k tei-k changed the title [WIP] Remove terratest Remove terratest Dec 10, 2020
feeblefakie
feeblefakie approved these changes Dec 11, 2020
View reviewed changes
Copy link
Collaborator

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie
Copy link
Collaborator

@ymorimo I'm merging it but please take a look when you get a chance.

@feeblefakie feeblefakie merged commit afc9682 into master Dec 11, 2020
@feeblefakie feeblefakie deleted the remove-terratest branch December 11, 2020 01:50
ymorimo
ymorimo reviewed Dec 11, 2020
View reviewed changes
Copy link
Contributor

@ymorimo ymorimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ymorimo
Copy link
Contributor

ymorimo commented Dec 11, 2020

It seems like workflows are failing in #244 after this is merged. #250 should fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymorimo ymorimo ymorimo left review comments

@feeblefakie feeblefakie feeblefakie approved these changes

Assignees

@tei-k tei-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tei-k @feeblefakie @ymorimo