Skip to content

Fix empty map bug in aws scalardl #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2020
Merged

Fix empty map bug in aws scalardl #251

merged 2 commits into from
Dec 16, 2020

Conversation

tei-k
Copy link
Contributor

@tei-k tei-k commented Dec 15, 2020 •
edited
Loading

Description

https://scalar-labs.atlassian.net/browse/DLT-7817

Bug in #244

Done

  • Use cassandra as default value.

@tei-k tei-k self-assigned this Dec 15, 2020
@tei-k tei-k changed the title [WIP] Fix empty map bug in aws scalardl Fix empty map bug in aws scalardl Dec 15, 2020
@tei-k tei-k requested review from feeblefakie and ymorimo December 15, 2020 05:31
feeblefakie
feeblefakie approved these changes Dec 15, 2020
View reviewed changes
Copy link
Collaborator

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tei-k Why terratest worked fine?

@tei-k
Copy link
Contributor Author

tei-k commented Dec 15, 2020 •
edited
Loading

Why terratest worked fine?

@feeblefakie

Since the current terratest is only for cassandra, So I did't use the following if statements.

start_on_initial_boot = var.scalardl.database == "cassandra" ? data.terraform_remote_state.cassandra.outputs.cassandra_start_on_initial_boot : false
provision_ids         = var.scalardl.database == "cassandra" ? join(",", data.terraform_remote_state.cassandra.outputs.cassandra_provision_ids) : ""

ref:
https://github.com/scalar-labs/scalar-terratest/blob/1bc6e1c65212ca3d8b5e94199b54c421be9f9df0/test/modules/awsdeploy/scalardl/locals.tf#L26-L27

@feeblefakie
Copy link
Collaborator

@ymorimo PTAL!

ymorimo
ymorimo approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@ymorimo ymorimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! 🙏

@feeblefakie feeblefakie merged commit 2294657 into master Dec 16, 2020
@feeblefakie feeblefakie deleted the fix-empty-map-bug-in-scalardl branch December 16, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymorimo ymorimo ymorimo approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

Assignees

@tei-k tei-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tei-k @feeblefakie @ymorimo