-
Notifications
You must be signed in to change notification settings - Fork 7
Add log viewer for monitor #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
relative-root = "/" | ||
listen-addr = ":8088" | ||
allow-download = true | ||
allow-commands = ["tail"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
custom config does not working. 🤔
https://github.com/gvalkov/tailon/blob/fffdf3fe57cef675341c44cbee946d8a81c3ff8a/main.go#L230
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I think upgrading versions should be separately done usually unless it is related to the changes.
@@ -1,4 +1,4 @@ | |||
version: "3.1" | |||
version: "3.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a required change? or just upgraded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just upgraded. Reveted in 648cfbd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice!
Description
https://scalar-labs.atlassian.net/browse/DLT-7695
Done