Skip to content

Conversation

tei-k
Copy link
Contributor

@tei-k tei-k commented Dec 16, 2020

@tei-k tei-k self-assigned this Dec 16, 2020
relative-root = "/"
listen-addr = ":8088"
allow-download = true
allow-commands = ["tail"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tei-k tei-k changed the title [WIP] Add log viewer for monitor Add log viewer for monitor Dec 17, 2020
@tei-k tei-k requested review from feeblefakie and ymorimo December 17, 2020 07:09
feeblefakie
feeblefakie previously approved these changes Dec 18, 2020
Copy link
Collaborator

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I think upgrading versions should be separately done usually unless it is related to the changes.

@@ -1,4 +1,4 @@
version: "3.1"
version: "3.7"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a required change? or just upgraded?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just upgraded. Reveted in 648cfbd

Copy link
Contributor

@ymorimo ymorimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice!

@feeblefakie feeblefakie merged commit 269c4c1 into master Dec 18, 2020
@feeblefakie feeblefakie deleted the add-log-viewer-for-monitor branch December 18, 2020 06:42
tei-k pushed a commit that referenced this pull request Jan 27, 2021
tei-k pushed a commit that referenced this pull request Jan 27, 2021
tei-k pushed a commit that referenced this pull request Jan 27, 2021
tei-k pushed a commit that referenced this pull request Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants