Support time-related data types in generic function

[jnmt]

Description

This PR adds time-related data type support in the generic function of object authenticity management. Similar to the ScalarDL SQL grammar, you can specify it with text literals that follow a specific format to put DATE, TIME, TIMESTAMP, and TIMESTAMPTZ values.

https://scalardb.scalar-labs.com/docs/latest/scalardb-sql/grammar/#date-and-time

Related issues and/or PRs

N/A

Changes made

• Add time-related data type support in the generic function of object authenticity management

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation to reflect the changes.
• I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
• Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
• Tests (unit, integration, etc.) have been added for the changes.
• My changes generate no new warnings.
• Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

Supported time-related data types in the generic function.

[gemini-code-assist]

Summary of Changes

Hello @jnmt, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the PutToMutableDatabase generic function by introducing support for various time-related data types. This enables users to store and manage DATE, TIME, TIMESTAMP, and TIMESTAMPTZ values directly within the mutable database, improving data fidelity and consistency. The changes include schema updates, new formatting utilities, and robust input validation to ensure data integrity.

Highlights

• New Data Type Support: The generic function PutToMutableDatabase now supports DATE, TIME, TIMESTAMP, and TIMESTAMPTZ data types, allowing for more precise time-related data storage.
• Schema and Formatting: Introduced new DateTimeFormatter constants for standard date and time literal formats, and updated the objects-table-schema.json to reflect the use of TIMESTAMP for the registered_at column.
• Robust Input Validation: Implemented parsing logic for the new time-related data types, including strict validation to ensure that input strings conform to the expected formats, throwing ContractContextException for invalid inputs.
• Expanded Test Coverage: Added comprehensive unit and integration tests to verify the correct handling of the new time-related data types, including successful data insertion and error handling for malformed inputs.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull Request Overview

This PR adds support for time-related data types (DATE, TIME, TIMESTAMP, and TIMESTAMPTZ) to the generic function for putting data to mutable databases. The implementation enables proper parsing, validation, and storage of these temporal data types with standardized formatters.

• Adds support for DATE, TIME, TIMESTAMP, and TIMESTAMPTZ data types in the PutToMutableDatabase function
• Implements proper parsing and validation logic for time-related data with standardized formatters
• Updates the database schema to use TIMESTAMP instead of BIGINT for the registered_at column

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
PutToMutableDatabase.java	Core implementation adding time-related data type support with parsing logic
Constants.java	Defines DateTimeFormatter constants for each supported time data type
PutToMutableDatabaseTest.java	Comprehensive test coverage for time-related data types and validation
GenericContractObjectAndCollectionEndToEndTest.java	Integration tests demonstrating timestamp usage
objects-table-schema.json	Schema update changing registered_at from BIGINT to TIMESTAMP

Comments suppressed due to low confidence (1)

generic-contracts/src/test/java/com/scalar/dl/genericcontracts/object/PutToMutableDatabaseTest.java:637

• The method name is inconsistent. It should be invoke_ColumnsWithInvalidTimeRelatedFormatGiven_ShouldThrowContractContextException to match the test method name above, but the actual helper method calls invoke_ColumnsWithUnmatchedTypeGiven_ShouldThrowContractContextException.

  private void invoke_ColumnsWithInvalidTimeRelatedFormatGiven_ShouldThrowContractContextException(

[gemini-code-assist]

Code Review

This pull request adds support for time-related data types (DATE, TIME, TIMESTAMP, TIMESTAMPTZ) in the generic PutToMutableDatabase function. The changes include new DateTimeFormatter constants, updates to the function logic to handle these new types, and corresponding additions to integration and unit tests. The implementation is solid, but I've found a few areas for improvement: in Constants.java, one of the new formatters is missing strict parsing settings; in PutToMutableDatabase.java, there's a piece of unreachable code that should be removed; and in PutToMutableDatabaseTest.java, a duplicated helper method was added which can be removed to reduce code duplication. These are minor issues, and addressing them will improve the code's consistency and maintainability. Overall, great work on adding this new functionality.

[feeblefakie]

LGTM! Thank you!

[choplin]

LGTM! Just left a nitpick comment.