Backport to branch(3.10) : Fix certificate and secret key version check and messages

[feeblefakie]

This is an automated backport of the following:

• Original PR: Fix certificate and secret key version check and messages #202
• Backported commit: cce9212

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a backport that addresses an issue where certificate and secret key versions could be set to zero, which is an invalid state. My changes enforce that these versions must be strictly greater than zero, improving the robustness of client configuration validation and providing clearer error messages when invalid versions are supplied.

Highlights

• Client Configuration Loading: I've updated the ClientConfig to correctly prioritize the digital signature certificate version (DS_CERT_VERSION) when loading client configurations, using the general certificate version (CERT_VERSION) as a fallback.
• Version Validation Enforcement: I've modified the validation logic in both DigitalSignatureIdentityConfig and HmacIdentityConfig to ensure that certificate and secret key versions are strictly positive (greater than zero). This prevents invalid configurations where these versions might be set to zero.
• Improved Error Messaging: I've enhanced the error messages in CommonError to clearly state that certificate and secret key versions must be greater than zero, providing more precise feedback for invalid inputs.
• Unit Test Coverage: I've added comprehensive unit tests in ClientConfigTest to verify that an IllegalArgumentException is thrown when invalid zero versions are provided for both current and deprecated certificate/secret key properties.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a backport that fixes certificate and secret key version checks. The changes correctly enforce that version numbers must be greater than zero, and also improve the logic for handling deprecated configuration properties by prioritizing the newer ones. The error messages and tests have been updated accordingly. The changes are solid, and I have one minor suggestion to improve test code clarity.

[gemini-code-assist]

This property setting is redundant because ClientConfig.ENTITY_ID is already set on line 779 and takes precedence over the deprecated ClientConfig.CERT_HOLDER_ID. Removing this line will make the test setup cleaner and less confusing.