Skip to content

Conversation

josh-wong
Copy link
Member

Description

This PR removes the ScalarDL escrow payment sample since it is outdated and no longer maintained.

Related issues and/or PRs

Changes made

  • Deleted the escrow payment sample doc and related files.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@kota2and3kan
Copy link
Contributor

I think we can keep this sample application in the scalardl repository even if it's not maintained at this time. This is because there is a possibility that we will update this sample application and move it to scalardl-samples in the future.

In other words:

  • It's not maintained now. So, we should not show it on the document site to users.
  • However, for future use, we can keep the original sample application code in this scalardl repository.

@feeblefakie @jnmt
What do you think?

@jnmt
Copy link
Collaborator

jnmt commented Sep 30, 2024

@josh-wong @kota2and3kan Thanks for the maintenance. We have a plan to reorganize this repository and the sample repository. I think we can keep it as is until that time, but it's not a strong opinion since we can revive it anytime.

@josh-wong
Copy link
Member Author

@kota2and3kan @jnmt Thanks. I didn't know that we're planning on updating this sample app in the future. In that case, I'm OK with keeping it.

I'll go ahead and close this PR.

@josh-wong josh-wong closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants