Skip to content

feat(instance): add servers filter in ListServersRequest #3391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2023
Merged

feat(instance): add servers filter in ListServersRequest #3391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
063d295
feat: update generated APIs
scaleway-bot Oct 4, 2023
eb2c726
Merge branch 'master' into v1.4077.0
remyleone Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/scw/testdata/test-all-usage-instance-server-list-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ ARGS:
[order] Define the order of the returned servers (creation_date_desc | creation_date_asc | modification_date_desc | modification_date_asc)
[private-networks.{index}] List Instances from the given Private Networks (use commas to separate them)
[private-nic-mac-address] List Instances associated with the given private NIC MAC address
[servers.{index}] List Instances from these server ids (use commas to separate them)
[organization-id] List only Instances of this Organization ID
[zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | fr-par-3 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2 | pl-waw-3 | all)

Expand Down
1 change: 1 addition & 0 deletions docs/commands/instance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1979,6 +1979,7 @@ scw instance server list [arg=value ...]
| order | One of: `creation_date_desc`, `creation_date_asc`, `modification_date_desc`, `modification_date_asc` | Define the order of the returned servers |
| private-networks.{index} | | List Instances from the given Private Networks (use commas to separate them) |
| private-nic-mac-address | | List Instances associated with the given private NIC MAC address |
| servers.{index} | | List Instances from these server ids (use commas to separate them) |
| organization-id | | List only Instances of this Organization ID |
| zone | Default: `fr-par-1`<br />One of: `fr-par-1`, `fr-par-2`, `fr-par-3`, `nl-ams-1`, `nl-ams-2`, `nl-ams-3`, `pl-waw-1`, `pl-waw-2`, `pl-waw-3`, `all` | Zone to target. If none is passed will use default zone from the config |

Expand Down
1 change: 1 addition & 0 deletions internal/namespaces/alias/testdata/test-alias-multiple-words.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ ARGS:
[order] Define the order of the returned servers (creation_date_desc | creation_date_asc | modification_date_desc | modification_date_asc)
[private-networks.{index}] List Instances from the given Private Networks (use commas to separate them)
[private-nic-mac-address] List Instances associated with the given private NIC MAC address
[servers.{index}] List Instances from these server ids (use commas to separate them)
[organization-id] List only Instances of this Organization ID
[zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | fr-par-3 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2 | pl-waw-3 | all)

Expand Down
1 change: 1 addition & 0 deletions internal/namespaces/alias/testdata/test-alias-one-word-aliases.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ ARGS:
[order] Define the order of the returned servers (creation_date_desc | creation_date_asc | modification_date_desc | modification_date_asc)
[private-networks.{index}] List Instances from the given Private Networks (use commas to separate them)
[private-nic-mac-address] List Instances associated with the given private NIC MAC address
[servers.{index}] List Instances from these server ids (use commas to separate them)
[organization-id] List only Instances of this Organization ID
[zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | fr-par-3 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2 | pl-waw-3 | all)

Expand Down
7 changes: 7 additions & 0 deletions internal/namespaces/instance/v1/instance_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,13 @@ func instanceServerList() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "servers.{index}",
Short: `List Instances from these server ids (use commas to separate them)`,
Required: false,
Deprecated: false,
Positional: false,
},
{
Name: "organization",
Short: `List only Instances of this Organization ID`,
Expand Down