Skip to content

fix(vpc): add better vizualisation for private network subnets #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix(vpc): add better vizualisation for private network subnets #3643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/namespaces/vpc/v2/custom_private_network.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,11 @@ func privateNetworkGetBuilder(c *core.Command) *core.Command {
Title: "Public Gateways",
HideIfEmpty: true,
},
{
FieldName: "Subnets",
Title: "Subnets",
HideIfEmpty: true,
},
},
}

Expand Down
31 changes: 14 additions & 17 deletions internal/namespaces/vpc/v2/testdata/test-get-private-network-multiple.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,14 @@
🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
🟩🟩🟩 STDOUT️ 🟩🟩🟩️
ID c48ea3b6-175a-4abf-9d30-9228973e425e
Name cli-pn-laughing-banzai
OrganizationID ee7bd9e1-9cbd-4724-b2f4-19e50f3cf38b
ProjectID ee7bd9e1-9cbd-4724-b2f4-19e50f3cf38b
Region fr-par
CreatedAt few seconds ago
UpdatedAt few seconds ago
Subnets.0.ID 8d377ac0-4649-44c5-b117-8b18dd171728
Subnets.0.CreatedAt few seconds ago
Subnets.0.UpdatedAt few seconds ago
Subnets.0.Subnet 172.16.72.0/22
Subnets.1.ID 2be627ab-cf3e-40c7-bd70-06e6fbc4fd17
Subnets.1.CreatedAt few seconds ago
Subnets.1.UpdatedAt few seconds ago
Subnets.1.Subnet fd4a:c18e:554d:c78a::/64
VpcID 53e50f63-f6c0-44f7-8576-d6edcb965d9c
DHCPEnabled true
ID c48ea3b6-175a-4abf-9d30-9228973e425e
Name cli-pn-laughing-banzai
OrganizationID ee7bd9e1-9cbd-4724-b2f4-19e50f3cf38b
ProjectID ee7bd9e1-9cbd-4724-b2f4-19e50f3cf38b
Region fr-par
CreatedAt few seconds ago
UpdatedAt few seconds ago
VpcID 53e50f63-f6c0-44f7-8576-d6edcb965d9c
DHCPEnabled true

Instance Servers:
ID NAME STATE NIC ID MAC ADDRESS
Expand All @@ -29,6 +21,11 @@ adea6c04-7694-4517-bdd4-a56fe6f21aba cli-test ready
Rdb Instances:
ID NAME STATE ENDPOINT ID
5a96db09-7370-4a56-97c2-43219aa510f4 cli-test ready ee102f58-a383-4823-83f0-945a1d3cfd12

Subnets:
ID CREATED AT UPDATED AT SUBNET
8d377ac0-4649-44c5-b117-8b18dd171728 few seconds ago few seconds ago 172.16.72.0/22
2be627ab-cf3e-40c7-bd70-06e6fbc4fd17 few seconds ago few seconds ago fd4a:c18e:554d:c78a::/64
🟩🟩🟩 JSON STDOUT 🟩🟩🟩
{
"id": "c48ea3b6-175a-4abf-9d30-9228973e425e",
Expand Down
31 changes: 14 additions & 17 deletions internal/namespaces/vpc/v2/testdata/test-get-private-network-simple.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,23 @@
🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
🟩🟩🟩 STDOUT️ 🟩🟩🟩️
ID 59428310-4d60-491c-98d2-9328e85d3cb1
Name cli-pn-stupefied-vaughan
OrganizationID ee7bd9e1-9cbd-4724-b2f4-19e50f3cf38b
ProjectID ee7bd9e1-9cbd-4724-b2f4-19e50f3cf38b
Region fr-par
CreatedAt few seconds ago
UpdatedAt few seconds ago
Subnets.0.ID b70e5a1e-a32a-44c9-8e81-9c9a500c2940
Subnets.0.CreatedAt few seconds ago
Subnets.0.UpdatedAt few seconds ago
Subnets.0.Subnet 172.16.96.0/22
Subnets.1.ID ab858a88-6d19-41f2-ac12-cc2e3176dffa
Subnets.1.CreatedAt few seconds ago
Subnets.1.UpdatedAt few seconds ago
Subnets.1.Subnet fd4a:c18e:554d:544a::/64
VpcID 53e50f63-f6c0-44f7-8576-d6edcb965d9c
DHCPEnabled true
ID 59428310-4d60-491c-98d2-9328e85d3cb1
Name cli-pn-stupefied-vaughan
OrganizationID ee7bd9e1-9cbd-4724-b2f4-19e50f3cf38b
ProjectID ee7bd9e1-9cbd-4724-b2f4-19e50f3cf38b
Region fr-par
CreatedAt few seconds ago
UpdatedAt few seconds ago
VpcID 53e50f63-f6c0-44f7-8576-d6edcb965d9c
DHCPEnabled true

Instance Servers:
ID NAME STATE NIC ID MAC ADDRESS
6f38747e-ad14-4eaf-8001-fc46273d829d cli-srv-festive-easley archived 49ec0211-2e16-4d5b-a9c0-8ec1e44c31e2 02:00:00:15:3a:07

Subnets:
ID CREATED AT UPDATED AT SUBNET
b70e5a1e-a32a-44c9-8e81-9c9a500c2940 few seconds ago few seconds ago 172.16.96.0/22
ab858a88-6d19-41f2-ac12-cc2e3176dffa few seconds ago few seconds ago fd4a:c18e:554d:544a::/64
🟩🟩🟩 JSON STDOUT 🟩🟩🟩
{
"id": "59428310-4d60-491c-98d2-9328e85d3cb1",
Expand Down