Skip to content

fix(container/function): remove deprecated mnq namespace fields #3690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2024
Merged

fix(container/function): remove deprecated mnq namespace fields #3690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f525729
feat: update generated APIs
scaleway-bot Feb 29, 2024
f3f8db4
Merge branch 'master' into v1.4656.0
yfodil Feb 29, 2024
6f3e963
Merge branch 'master' into v1.4656.0
Codelax Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions cmd/scw/testdata/test-all-usage-container-trigger-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ ARGS:
[scw-nats-config.mnq-region] Region in which the Messaging and Queuing project is activated.
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

DEPRECATED ARGS:
[scw-sqs-config.mnq-namespace-id]
[scw-nats-config.mnq-namespace-id]

FLAGS:
-h, --help help for create

Expand Down
4 changes: 0 additions & 4 deletions cmd/scw/testdata/test-all-usage-function-trigger-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ ARGS:
[scw-nats-config.mnq-region] Region in which the Messaging and Queuing project is activated.
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

DEPRECATED ARGS:
[scw-sqs-config.mnq-namespace-id]
[scw-nats-config.mnq-namespace-id]

FLAGS:
-h, --help help for create

Expand Down
2 changes: 0 additions & 2 deletions docs/commands/container.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,11 +684,9 @@ scw container trigger create [arg=value ...]
| name | Required | Name of the trigger |
| container-id | Required | ID of the container to trigger |
| description | | Description of the trigger |
| ~~scw-sqs-config.mnq-namespace-id~~ | Deprecated | |
| scw-sqs-config.queue | | Name of the SQS queue the trigger should listen to |
| scw-sqs-config.mnq-project-id | | ID of the Messaging and Queuing project |
| scw-sqs-config.mnq-region | | Region in which the Messaging and Queuing project is activated. |
| ~~scw-nats-config.mnq-namespace-id~~ | Deprecated | |
| scw-nats-config.subject | | Name of the NATS subject the trigger should listen to |
| scw-nats-config.mnq-nats-account-id | | ID of the Messaging and Queuing NATS account |
| scw-nats-config.mnq-project-id | | ID of the Messaging and Queuing project |
Expand Down
2 changes: 0 additions & 2 deletions docs/commands/function.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,11 +741,9 @@ scw function trigger create [arg=value ...]
| name | Required | Name of the trigger |
| function-id | Required | ID of the function to trigger |
| description | | Description of the trigger |
| ~~scw-sqs-config.mnq-namespace-id~~ | Deprecated | |
| scw-sqs-config.queue | | Name of the SQS queue the trigger should listen to |
| scw-sqs-config.mnq-project-id | | ID of the Messaging and Queuing project |
| scw-sqs-config.mnq-region | | Region in which the Messaging and Queuing project is activated. |
| ~~scw-nats-config.mnq-namespace-id~~ | Deprecated | |
| scw-nats-config.subject | | Name of the NATS subject the trigger should listen to |
| scw-nats-config.mnq-nats-account-id | | ID of the Messaging and Queuing NATS account |
| scw-nats-config.mnq-project-id | | ID of the Messaging and Queuing project |
Expand Down
12 changes: 0 additions & 12 deletions internal/namespaces/container/v1beta1/container_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1402,12 +1402,6 @@ func containerTriggerCreate() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "scw-sqs-config.mnq-namespace-id",
Required: false,
Deprecated: true,
Positional: false,
},
{
Name: "scw-sqs-config.queue",
Short: `Name of the SQS queue the trigger should listen to`,
Expand All @@ -1429,12 +1423,6 @@ func containerTriggerCreate() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "scw-nats-config.mnq-namespace-id",
Required: false,
Deprecated: true,
Positional: false,
},
{
Name: "scw-nats-config.subject",
Short: `Name of the NATS subject the trigger should listen to`,
Expand Down
12 changes: 0 additions & 12 deletions internal/namespaces/function/v1beta1/function_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1500,12 +1500,6 @@ func functionTriggerCreate() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "scw-sqs-config.mnq-namespace-id",
Required: false,
Deprecated: true,
Positional: false,
},
{
Name: "scw-sqs-config.queue",
Short: `Name of the SQS queue the trigger should listen to`,
Expand All @@ -1527,12 +1521,6 @@ func functionTriggerCreate() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "scw-nats-config.mnq-namespace-id",
Required: false,
Deprecated: true,
Positional: false,
},
{
Name: "scw-nats-config.subject",
Short: `Name of the NATS subject the trigger should listen to`,
Expand Down