Skip to content

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Jan 8, 2025

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@yfodil yfodil added load-balancer Load-balancer issues, bugs and feature requests tests labels Jan 8, 2025
@yfodil yfodil self-assigned this Jan 8, 2025
@yfodil yfodil marked this pull request as ready for review January 8, 2025 15:06
@yfodil yfodil requested a review from remyleone as a code owner January 8, 2025 15:06
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.71%. Comparing base (5bf53e0) to head (ddb8270).
Report is 427 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/lb/v1/custom_lb.go 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4409      +/-   ##
==========================================
- Coverage   75.45%   70.71%   -4.74%     
==========================================
  Files         202      297      +95     
  Lines       44323    65894   +21571     
==========================================
+ Hits        33444    46598   +13154     
- Misses       9653    17654    +8001     
- Partials     1226     1642     +416     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yfodil yfodil added this pull request to the merge queue Jan 10, 2025
Merged via the queue into scaleway:master with commit 3bc2346 Jan 10, 2025
13 checks passed
@yfodil yfodil deleted the fix/dangling-lb-flex-ips branch January 10, 2025 15:58
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
load-balancer Load-balancer issues, bugs and feature requests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants