Skip to content

feat(instance): add create_server wrapper #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 9, 2025
Merged

feat(instance): add create_server wrapper #1299

merged 5 commits into from
Oct 9, 2025
+93 −3

Conversation

Laure-di
Copy link
Contributor

@Laure-di Laure-di commented Oct 8, 2025

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

@Laure-di Laure-di requested a review from a team as a code owner October 8, 2025 07:53
@Laure-di Laure-di marked this pull request as draft October 8, 2025 07:53
@Laure-di Laure-di self-assigned this Oct 8, 2025
@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label Oct 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@855c526). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1299   +/-   ##
=======================================
  Coverage        ?   56.31%           
=======================================
  Files           ?       74           
  Lines           ?    11524           
  Branches        ?     1481           
=======================================
  Hits            ?     6490           
  Misses          ?     4681           
  Partials        ?      353

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laure-di Laure-di changed the title doc(instance): guide how to create an instance @Laure-di doc(instance): guide how to create an instance Oct 8, 2025
@Laure-di Laure-di changed the title doc(instance): guide how to create an instance fix(instance): make create_instance_server public Oct 8, 2025
@Laure-di Laure-di force-pushed the instance-doc branch 3 times, most recently from c3f41b5 to 8bbb500 Compare October 8, 2025 10:09
@Laure-di Laure-di changed the title fix(instance): make create_instance_server public feat(instance): add create_instance_server wrapper Oct 8, 2025
@Laure-di Laure-di force-pushed the instance-doc branch 2 times, most recently from 5eb4445 to 6db27fb Compare October 8, 2025 10:17
@Laure-di Laure-di marked this pull request as ready for review October 8, 2025 15:06
@Laure-di Laure-di requested a review from remyleone as a code owner October 8, 2025 15:06
remyleone
remyleone reviewed Oct 8, 2025
View reviewed changes
@Laure-di Laure-di changed the title feat(instance): add create_instance_server wrapper feat(instance): add create_server wrapper Oct 8, 2025
@remyleone remyleone added this pull request to the merge queue Oct 9, 2025
Merged via the queue into scaleway:main with commit 9e8d30f Oct 9, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@remyleone remyleone remyleone approved these changes

Assignees

@Laure-di Laure-di

Labels

instance Instance issues, bugs and feature requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Laure-di @codecov-commenter @remyleone