Skip to content

feat(s2s_vpn): accept custom private interco IPs on connection creation #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
Merged

feat(s2s_vpn): accept custom private interco IPs on connection creation #1301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions scaleway-async/scaleway_async/s2s_vpn/v1alpha1/marshalling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@ def unmarshal_BgpSession(data: Any) -> BgpSession:
else:
args["private_ip"] = None

field = data.get("peer_private_ip", None)
if field is not None:
args["peer_private_ip"] = field
else:
args["peer_private_ip"] = None

return BgpSession(**args)


Expand Down Expand Up @@ -783,6 +789,12 @@ def marshal_CreateConnectionRequestBgpConfig(
if request.routing_policy_id is not None:
output["routing_policy_id"] = request.routing_policy_id

if request.private_ip is not None:
output["private_ip"] = request.private_ip

if request.peer_private_ip is not None:
output["peer_private_ip"] = request.peer_private_ip

return output


Expand Down
3 changes: 3 additions & 0 deletions scaleway-async/scaleway_async/s2s_vpn/v1alpha1/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ def __str__(self) -> str:
class BgpSession:
routing_policy_id: str
private_ip: str
peer_private_ip: str


@dataclass
Expand All @@ -190,6 +191,8 @@ class VpnGatewayPublicConfig:
@dataclass
class CreateConnectionRequestBgpConfig:
routing_policy_id: str
private_ip: Optional[str] = None
peer_private_ip: Optional[str] = None


@dataclass
Expand Down
12 changes: 12 additions & 0 deletions scaleway/scaleway/s2s_vpn/v1alpha1/marshalling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@ def unmarshal_BgpSession(data: Any) -> BgpSession:
else:
args["private_ip"] = None

field = data.get("peer_private_ip", None)
if field is not None:
args["peer_private_ip"] = field
else:
args["peer_private_ip"] = None

return BgpSession(**args)


Expand Down Expand Up @@ -783,6 +789,12 @@ def marshal_CreateConnectionRequestBgpConfig(
if request.routing_policy_id is not None:
output["routing_policy_id"] = request.routing_policy_id

if request.private_ip is not None:
output["private_ip"] = request.private_ip

if request.peer_private_ip is not None:
output["peer_private_ip"] = request.peer_private_ip

return output


Expand Down
3 changes: 3 additions & 0 deletions scaleway/scaleway/s2s_vpn/v1alpha1/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ def __str__(self) -> str:
class BgpSession:
routing_policy_id: str
private_ip: str
peer_private_ip: str


@dataclass
Expand All @@ -190,6 +191,8 @@ class VpnGatewayPublicConfig:
@dataclass
class CreateConnectionRequestBgpConfig:
routing_policy_id: str
private_ip: Optional[str] = None
peer_private_ip: Optional[str] = None


@dataclass
Expand Down