build,scripts,salt: Pin salt version in bootstrap and restore and set repo priority to 1

[TeddyAndrieux]

Component:

'salt', 'build', 'scripts'

Context:

#2704

Summary:

In bootstrap and restore we install salt-minion on the node so we need
to pin the salt version we want to install and not just install the one
yum will find depending on various things (like available versions,
priority on repos, ...).
Also set the priority to 1 on all our repos so that our repositories has
priority over others if the yum-plugin-priorities package is
installed.
NOTE: If yum-plugin-priorities is installed and priority is set on one
repos then other repos with the same package will just be ignored
(e.g.: epel installed with priority=98 we cannot install salt-3000.3
as salt-3000.3 is excluded because a repo with some priority has the
package in a different version)

Test:

Tested manually with

[epel]
name=Extra Packages for Enterprise Linux 7 - $basearch
#baseurl=http://download.fedoraproject.org/pub/epel/7/$basearch
metalink=https://mirrors.fedoraproject.org/metalink?repo=epel-7&arch=$basearch
failovermethod=priority
enabled=1
gpgcheck=1
gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7
priority=9

And yum-plugin-priorities installed and it works well (even if salt-2015 is already installed before bootstrapping)

---

Fixes: #2704

[bert-e]

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

[bert-e]

Integration data created

I have created the integration data for the additional destination branches.

• this pull request will merge bugfix/GH-2704-pin-salt-version-in-bootstrap into
  development/2.4
• w/2.5/bugfix/GH-2704-pin-salt-version-in-bootstrap will be merged into development/2.5
• w/2.6/bugfix/GH-2704-pin-salt-version-in-bootstrap will be merged into development/2.6

The following branches will NOT be impacted:

• development/1.0
• development/1.1
• development/1.2
• development/1.3
• development/2.0
• development/2.1
• development/2.2
• development/2.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• one peer

Peer approvals must include at least 1 approval from the following list:

• @thomasdanan

• @alexandre-allard-scality

• @tcarmet

• @nootal

• @TeddyAndrieux

• @lucieleonard

• @gdemonet

• @sayf-eddine-scality

• @NicolasT

• @jbertran

• @MonPote

• @carlito-scality

• @slaperche-scality

• @cmonfort

[TeddyAndrieux]

/approve

[bert-e]

Build failed

The build for commit did not succeed in branch w/2.5/bugfix/GH-2704-pin-salt-version-in-bootstrap.

The following options are set: approve

[bert-e]

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

• ✔️ development/2.4

• ✔️ development/2.5

• ✔️ development/2.6

The following branches will NOT be impacted:

• development/1.0
• development/1.1
• development/1.2
• development/1.3
• development/2.0
• development/2.1
• development/2.2
• development/2.3

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

• Any commit you add on the source branch will trigger a new cycle after the
  current queue is merged.
• Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/2.4

• ✔️ development/2.5

• ✔️ development/2.6

The following branches have NOT changed:

• development/1.0
• development/1.1
• development/1.2
• development/1.3
• development/2.0
• development/2.1
• development/2.2
• development/2.3

Please check the status of the associated issue GH-2704.

Goodbye teddyandrieux.