Skip to content

feat: Added jsonplaceholder example #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2020
Merged

feat: Added jsonplaceholder example #10

merged 2 commits into from
Sep 14, 2020

Conversation

jfollmann
Copy link
Member

Hi @camilamaia,

I added another example using the jsonplaceholder API (https://jsonplaceholder.typicode.com). Issue #5 .

Congratulations on the excellent work. 😍

@jfollmann jfollmann requested review from a team as code owners September 11, 2020 16:07
@jfollmann
Copy link
Member Author

note: two requests are showing errors, because the API is in trouble... hehe

Copy link
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is a super complete example! Thanks for that 😍

We were missing a complete example with lots of different http methods and multiple spec files. Thanks for the contribution!

I just left a minor comment, but overall it is awesome!

@camilamaia
Copy link
Member

camilamaia commented Sep 13, 2020

note: two requests are showing errors, because the API is in trouble... hehe

Super interesting to see how the API is breaking for PUT methods!

Copy link
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camilamaia camilamaia merged commit d0601a6 into scanapi:master Sep 14, 2020
@camilamaia
Copy link
Member

Hey @jfollmann, I am gonna send you an invite to join the ScanAPI org on GitHub. We invite everyone that has contributed with a merged PR in any of our repos. Here you can check our Community Continuity Guidelines so you can understand better how it works.

And once again, thank you very much!! 🙇‍♀️

@jfollmann
Copy link
Member Author

Thanks @camilamaia. I hope to be able to contribute more. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants