Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SciView: fix removing volumes #421

Merged
merged 1 commit into from
Oct 25, 2021
Merged

SciView: fix removing volumes #421

merged 1 commit into from
Oct 25, 2021

Conversation

frauzufall
Copy link
Collaborator

I cannot remove volumes with the latest version on master, this fixes it. It will not remove more than entry from the imageToVolumeMap though, not sure if it should be able to do that.

@kephale
Copy link
Member

kephale commented Oct 25, 2021

It does need to remove multiple entries from imageToVolumeMap. I should clarify that somewhere.

imageToVolumeMap can have multiple keys point to the same volumes (e.g. a SourceAndConerter and an IterableInterval for the same image can point to the same volume)

@kephale
Copy link
Member

kephale commented Oct 25, 2021

@frauzufall yeah, makes sense. Silly original implementation :X

@frauzufall
Copy link
Collaborator Author

Thanks - I changed it to be able to remove multiple keys - it still fixes the issue I had with it iterating over a map while removing entries from the map.

@kephale kephale merged commit 74b22a4 into master Oct 25, 2021
@kephale kephale deleted the fix-remove-volumes branch October 25, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants